Hi mishin,
Your distribution for July is Data-MessagePack:
https://metacpan.org/release/Data-MessagePack
You should be able to find your dist on github at:
https://github.com/msgpack/msgpack-perl
Notes on your distribution:
* The distribution has CPAN Testers failures, so you could look at those:
http://www.cpantesters.org/distro/D/Data-MessagePack.html
* The distribution has CPANTS warnings - check out its page for details:
http://cpants.cpanauthors.org/dist/Data-MessagePack
If you really can't work with this dist, get in touch to request
a new assignment. The list of assignments will be published in 5 days.
When you've completed your assignment, please send me email with subject
"I'm done". Include your github username in the body of your email.
You should have done at least one pull request, but you don't have to
wait for it to be merged when you claim "done", that's up to you.
You can discuss ideas for your PR in a number of places:
a. The mailing list
b. The #pr-challenge channel on irc.perl.org
Please get in touch with the author of your assigned dist, to see if there's
anything they'd like you to do, and to check any ideas you might have.
If you decide to drop out, please let me know, by sending an email "I quit",
including your github username.
Have fun,
Neil
So CPANTS has trouble
Your distribution for July is Data-MessagePack:
https://metacpan.org/rele
You should be able to find your dist on github at:
https://github.com/msgpac
Notes on your distribution:
* The distribution has CPAN Testers failures, so you could look at those:
http://www.cpantesters.or
* The distribution has CPANTS warnings - check out its page for details:
http://cpants.cpanauthors
If you really can't work with this dist, get in touch to request
a new assignment. The list of assignments will be published in 5 days.
When you've completed your assignment, please send me email with subject
"I'm done". Include your github username in the body of your email.
You should have done at least one pull request, but you don't have to
wait for it to be merged when you claim "done", that's up to you.
You can discuss ideas for your PR in a number of places:
a. The mailing list
b. The #pr-challenge channel on irc.perl.org
Please get in touch with the author of your assigned dist, to see if there's
anything they'd like you to do, and to check any ideas you might have.
If you decide to drop out, please let me know, by sending an email "I quit",
including your github username.
Have fun,
Neil
So CPANTS has trouble
Kwalitee Fails
Core metrics
Excellent. This distribution passes all the core metrics.
Extra metrics
These fails affect your total Kwalitee score, but don't affect the one for the Game. Some of them should be fixed by all means. Others are just matters of taste.
metric | remedy |
---|---|
use warnings |
This distribution does not 'use warnings;' (or its equivalents) in all of its modules. Note that this is not about that your modules actually warn when something bad happens. It's bad if nobody can tell if a module warns or not, without reading the source code of your favorite module that actually enforces warnings. In other words, it's bad if someone feels the need to add 'use warnings' to your modules.
Add 'use warnings' (or its equivalents) to all modules (this will require perl > 5.6), or convince us that your favorite module is well-known enough and people can easily see the modules warn when something bad happens.
|
Experimental metrics
These fails are not serious and don't affect your Kwalitee scores at all.
metric | remedy |
---|---|
meta yml has provides |
This distribution does not have a list of provided modules defined in META.yml.
Add all modules contained in this distribution to the META.yml field 'provides'. Module::Build or Dist::Zilla::Plugin::MetaProvides do this automatically for you.
|
has separate license file |
This distribution does not have a LICENSE or LICENCE file in its root directory.
This is not a critical issue. Currently mainly informative for the CPANTS authors. It might be removed later.
|
for the beginning I add "use warnings" to https://github.com/mishin/msgpack-perl/blob/master/lib/Data/MessagePack/Boolean.pm
pull request Done!
second, adding separate licence
so these changes megred in one pull request
third, I dont know, acccording to http://cpants.cpanauthors.org/author/gfuji
Data-Clone | 2014-05-06 | 131.429 |
prereq_matches_use
|
Data-MessagePack | 2013-09-01 | 131.429 | |
Data-Util | 2014-03-05 | 128.571 |
I think it's enough
Комментариев нет:
Отправить комментарий